Skip to content

[CMake] Pass SYCL_RT_ZSTD_AVAILABLE for no_cgh unittests #20231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

[CMake] Pass SYCL_RT_ZSTD_AVAILABLE for no_cgh unittests #20231

merged 1 commit into from
Sep 29, 2025

Conversation

@jsji
Copy link
Contributor

@jsji jsji commented Sep 28, 2025

#19294 added new _no_cgh version, need to pass the macros to
fix the build failures.

@jsji
Pass SYCL_RT_ZSTD_AVAILABLE for no_cgh unittests
df38289 
intel#19294 added new _no_cgh version, need to pass the macros to
fix the build failures.
@jsji jsji requested a review from a team as a code owner September 28, 2025 18:33
@jsji jsji requested a review from cperkinsintel September 28, 2025 18:33
@jsji jsji changed the title Pass SYCL_RT_ZSTD_AVAILABLE for no_cgh unittests [CMake] Pass SYCL_RT_ZSTD_AVAILABLE for no_cgh unittests Sep 28, 2025
@uditagarwal97 uditagarwal97 merged commit 2ffa3a0 into intel:sycl Sep 29, 2025
49 of 54 checks passed
@uditagarwal97
Copy link
Contributor

@slawekptak SchedulerTest.HostTaskCleanup unit test failed with no handler path. Can you please check this out? This might be a flaky failure, I don't recall seeing this failure anywhere else.

25-09-29T16:19:22.0438257Z [ RUN      ] SchedulerTest.HostTaskCleanup
2025-09-29T16:19:22.0438881Z #0 0x00007ff6761dd5ab sycl::_V1::detail::adapter_impl::call_nocheck D:\github\actions-runner\_work\llvm\llvm\src\sycl\source\detail\adapter_impl.hpp:129:0
2025-09-29T16:19:22.0439406Z #1 0x00007ff6761dd5ab sycl::_V1::detail::queue_impl::~queue_impl(void) D:\github\actions-runner\_work\llvm\llvm\src\sycl\source\detail\queue_impl.hpp:257:0
2025-09-29T16:19:22.0439946Z #2 0x00007ff6763c395c std::_Ref_count_base::_Decwref C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\memory:1166:0
2025-09-29T16:19:22.0440619Z #3 0x00007ff6763c395c std::_Ref_count_base::_Decref C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\memory:1161:0
2025-09-29T16:19:22.0441250Z #4 0x00007ff6763c395c std::_Ptr_base<sycl::_V1::detail::queue_impl>::_Decref C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\memory:1377:0
2025-09-29T16:19:22.0441927Z #5 0x00007ff6763c395c std::shared_ptr<sycl::_V1::detail::queue_impl>::~shared_ptr C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\memory:1682:0
2025-09-29T16:19:22.0442732Z #6 0x00007ff6763c395c sycl::_V1::detail::Scheduler::NotifyHostTaskCompletion(class sycl::_V1::detail::Command *) D:\github\actions-runner\_work\llvm\llvm\src\sycl\source\detail\scheduler\scheduler.cpp:517:0
2025-09-29T16:19:22.0443552Z #7 0x00007ff6763bc75d std::unique_ptr<sycl::_V1::detail::tls_code_loc_t,std::default_delete<sycl::_V1::detail::tls_code_loc_t> >::~unique_ptr C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\memory:3408:0
2025-09-29T16:19:22.0444198Z #8 0x00007ff6763bc75d sycl::_V1::detail::DispatchHostTask::operator()(void) const D:\github\actions-runner\_work\llvm\llvm\src\sycl\source\detail\scheduler\commands.cpp:493:0
2025-09-29T16:19:22.0444803Z #9 0x00007ff6762c2ffc std::_Mutex_base::lock C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\mutex:52:0
2025-09-29T16:19:22.0445371Z #10 0x00007ff6762c2ffc std::unique_lock<std::mutex>::lock C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\mutex:198:0
2025-09-29T16:19:22.0445901Z #11 0x00007ff6762c2ffc sycl::_V1::detail::ThreadPool::worker(void) D:\github\actions-runner\_work\llvm\llvm\src\sycl\source\detail\thread_pool.hpp:79:0
2025-09-29T16:19:22.0446896Z #12 0x00007ff6762c2e4e std::thread::_Invoke<class std::tuple<class `private: void __cdecl sycl::_V1::detail::ThreadPool::start(void)'::`1'::<lambda_1>>, 0>(void *) C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.43.34808\include\thread:61:0
2025-09-29T16:19:22.0447224Z #13 0x00007ffc3c4e37b0 (C:\WINDOWS\System32\ucrtbase.dll+0x37b0)
2025-09-29T16:19:22.0447381Z 
2025-09-29T16:19:22.0447587Z #14 0x00007ffc3e98e8d7 (C:\WINDOWS\System32\KERNEL32.DLL+0x2e8d7)
2025-09-29T16:19:22.0447593Z 
2025-09-29T16:19:22.0447775Z #15 0x00007ffc3ee68d9c (C:\WINDOWS\SYSTEM32\ntdll.dll+0x8d9c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsji @uditagarwal97